Fix PHP 8.4 external extension ABI - #2476
Open
chubes4 wants to merge 3 commits into
Open
Conversation
chubes4
marked this pull request as ready for review
September 4, 2026 12:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2474.
Summary
mysqli_polltimeout fix from Fix mysqli_poll timeouts in PHP-WASM WordPress/wordpress-playground#4170Why both overlays are carried
Both upstream fixes are required, and neither is available in a released package:
mysqli_polltimeout fixA carried overlay must be paired with the driver it runs under. Bumping the driver to 3.1.52 while leaving the PHP 8.3 overlay built against 3.1.46 produced a version skew that hung inside
zif_mysqli_polluntil the recipe timed out. The 8.3 overlay is therefore rebuilt from #4170 against 3.1.52, for bothasyncifyandjspi, so whichever mode the runtime selects carries the fix.Both overlays record their upstream revision, source package, and tree digest in
runtime-overlays/, and both become deletable as soon as their upstream change ships.Verified
tests/mysqli-poll.integration.test.tspasses against the rebuilt 8.3 overlay (PHP 8.3.33, MariaDB)npm run test:php-wasm-external-extension-abinpm run test:php-wasm-runtime-rejection-any-commandnpm run test:phpunit-runtime-rejectionnpm run test:release-package-coveragenpm run build,npx patch-package --check,git diff --checkA PHP 8.4 JSPI extension workload that previously failed at startup with an unnamed
TypeError: resolved is not a functionnow boots PHP 8.4.25, loads its extension, and reaches command dispatch.Known limitation
The
jspiruntime is carried and rebuilt but not directly exercised: JSPI feature detection reports unavailable on the Node versions used here, soasyncifyis the mode under test. Carrying both avoids a silent hang if selection changes.AI assistance
OpenAI GPT-5.6 Sol via OpenCode traced the PHP.wasm ABI mismatch, diagnosed the driver/overlay version skew behind the mysqli_poll timeout, rebuilt both PHP 8.3 runtimes from the upstream fix, assembled the provenance-bound overlays, and implemented the packaging and regression coverage. Reviewed by Chris Huber.